[C++/Py] Rubinum OfflineShop [Full]

[Andi]

*Descriere:

Acesta este sistemul de OfflineShop oficial de la serverul Rubinum

*Poze / Video (obligatoriu):





*Link download:

Conținut: Ascuns

Reacționează la acest mesaj și conținutul se va afișa automat.

Conținut: Ascuns

Reacționează la acest mesaj și conținutul se va afișa automat.

[Kagijin]

Hey everyone! I took some time to deeply analyze the source code provided in this release. Here is a quick review of what to expect:

**The Good:**
* The base is very modern and well-structured.
* It uses a virtual grid system when closing the shop, which brilliantly prevents item loss and core crashes if the player's inventory is full.
* Fully compatible with modern server files (like TMP4, marty etc..)

** Missing Files:**
* The DB Server will **not** compile as is. The `Makefile` inside the `db` folder calls for `ClientManagerShop.cpp` and `Shop.cpp`, but these files are completely missing.

**Critical Security Flaw (Infinite Yang Exploit):**
* There is a severe race condition in `input_main.cpp` inside the `CInputMain::WithdrawShopStash` function. The system waits for the DB's success response before deducting the gold locally. Someone using a packet sender can spam the withdraw packet and easily duplicate their Yang.

**Database Warning:**
* Do not drop the provided raw `.frm`, `.MYD`, and `.MYI` files directly into your `/var/db/mysql/` directory. Depending on your MySQL/MariaDB version, this can easily corrupt your database. It's much safer to recreate the tables using standard SQL queries via Navicat/HeidiSQL.

Hope this helps anyone trying to implement or fix it!

[Andi]

Hey everyone! I took some time to deeply analyze the source code provided in this release. Here is a quick review of what to expect:

**The Good:**
* The base is very modern and well-structured.
* It uses a virtual grid system when closing the shop, which brilliantly prevents item loss and core crashes if the player's inventory is full.
* Fully compatible with modern server files (like TMP4, marty etc..)

** Missing Files:**
* The DB Server will **not** compile as is. The `Makefile` inside the `db` folder calls for `ClientManagerShop.cpp` and `Shop.cpp`, but these files are completely missing.

**Critical Security Flaw (Infinite Yang Exploit):**
* There is a severe race condition in `input_main.cpp` inside the `CInputMain::WithdrawShopStash` function. The system waits for the DB's success response before deducting the gold locally. Someone using a packet sender can spam the withdraw packet and easily duplicate their Yang.

**Database Warning:**
* Do not drop the provided raw `.frm`, `.MYD`, and `.MYI` files directly into your `/var/db/mysql/` directory. Depending on your MySQL/MariaDB version, this can easily corrupt your database. It's much safer to recreate the tables using standard SQL queries via Navicat/HeidiSQL.

Hope this helps anyone trying to implement or fix it!

I am sorry but not exist another version

[DaKa]

Hey everyone! I took some time to deeply analyze the source code provided in this release. Here is a quick review of what to expect:

**The Good:**
* The base is very modern and well-structured.
* It uses a virtual grid system when closing the shop, which brilliantly prevents item loss and core crashes if the player's inventory is full.
* Fully compatible with modern server files (like TMP4, marty etc..)

** Missing Files:**
* The DB Server will **not** compile as is. The `Makefile` inside the `db` folder calls for `ClientManagerShop.cpp` and `Shop.cpp`, but these files are completely missing.

**Critical Security Flaw (Infinite Yang Exploit):**
* There is a severe race condition in `input_main.cpp` inside the `CInputMain::WithdrawShopStash` function. The system waits for the DB's success response before deducting the gold locally. Someone using a packet sender can spam the withdraw packet and easily duplicate their Yang.

**Database Warning:**
* Do not drop the provided raw `.frm`, `.MYD`, and `.MYI` files directly into your `/var/db/mysql/` directory. Depending on your MySQL/MariaDB version, this can easily corrupt your database. It's much safer to recreate the tables using standard SQL queries via Navicat/HeidiSQL.

Hope this helps anyone trying to implement or fix it!

Yeah, these issues can be fixed.. but the question is. who will provide them to you or us for free?
And all the developers seem to be working solo from what I can see.. they wouldn't share their solutions with anyone.